-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] styleOverrides does not support Theme typings #5816
Comments
noticed same issue, would be nice to have a patch release soon. |
It makes sense, how the theme should be extended has changed after mui/material-ui#30524 e.g. https://mui.com/material-ui/about-the-lab/#typescript export interface LabComponents {
MuiLoadingButton?: {
defaultProps?: ComponentsProps['MuiLoadingButton'];
styleOverrides?: ComponentsOverrides<Theme>['MuiLoadingButton'];
variants?: ComponentsVariants['MuiLoadingButton'];
}; |
@oliviertassinari Should I change/add something to the linked PRs? Is implementation correct? |
@oliviertassinari This issue is also presented in "DatePickerPro" component. Can I create PR in scope of current issue or separate issue should be created? |
Duplicates
Latest version
Current behavior 😯
Usage of
theme
object in callback of styleOverrides causing ts error: Object is of type 'unknown'. Issue exist inDataGrid
andDataGridPro
components.Expected behavior 🤔
There are no ts errors presented.
theme
object has correct typing.Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/datagridpro-styleoverrides-issue-0k8c4r
Context 🔦
No response
Your environment 🌎
No response
Order ID 💳 (optional)
No response
The text was updated successfully, but these errors were encountered: