Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Improve typing for styleOverrides #5817

Closed
wants to merge 2 commits into from
Closed

[DataGridPro] Improve typing for styleOverrides #5817

wants to merge 2 commits into from

Conversation

iigrik
Copy link
Contributor

@iigrik iigrik commented Aug 17, 2022

Fixes #5816

@mui-bot
Copy link

mui-bot commented Aug 17, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 348.9 658.7 547.1 495.1 121.805
Sort 100k rows ms 568.9 1,100.8 864.3 871.08 171.639
Select 100k rows ms 225.6 440.6 317.4 311.36 74.054
Deselect 100k rows ms 188.3 362.8 214.3 236.7 64.033

Generated by 🚫 dangerJS against ebb6cbb

@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Aug 17, 2022
@m4theushw
Copy link
Member

Could you move the changes here to #5818 and close #5818? You can have a single PR changing both DataGrid versions.

@iigrik
Copy link
Contributor Author

iigrik commented Aug 20, 2022

@m4theushw Done. Please check.

@DanailH
Copy link
Member

DanailH commented Sep 12, 2022

No need for this one.

@DanailH DanailH closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] styleOverrides does not support Theme typings
5 participants
@iigrik @mui-bot @m4theushw @DanailH @oliviertassinari