Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Revert the link in the priority support ticket description #10517

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

michelengelen
Copy link
Member

just a revert of #10495

@michelengelen michelengelen self-assigned this Sep 29, 2023
@DanailH DanailH changed the title [support] reverts the link in the priority support ticket description [core] Reverts the link in the priority support ticket description Sep 29, 2023
@mui-bot
Copy link

mui-bot commented Sep 29, 2023

Deploy preview: https://deploy-preview-10517--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 25af267

@michelengelen michelengelen added the external dependency Blocked by external dependency, we can’t do anything about it label Sep 29, 2023
@DanailH
Copy link
Member

DanailH commented Sep 29, 2023

One note regarding the prefixes for the PR titles - for things that are not related to a particular component or deal with the component internals we use [core]. for docs there is the [docs] and then we have [test] and the localization one. Based on this the script for the changelog works the way it does now. Now, if there is a need we can always add more descriptive prefixes but for now the ones we have seem enough.

@DanailH DanailH changed the title [core] Reverts the link in the priority support ticket description [core] Revert the link in the priority support ticket description Sep 29, 2023
@michelengelen michelengelen enabled auto-merge (squash) September 29, 2023 14:03
@michelengelen michelengelen merged commit b59be72 into mui:master Sep 29, 2023
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Sep 29, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 29, 2023

for things that are not related to a particular component or deal with the component internals we use [core]

@DanailH I wonder if we should create a new scope soon or later, I'm not sure exactly how to call it: support-infra, community-infra, contribution-infra. We will see if this becomes frequent enough to make a scope of effective (a good way to discriminate between issues/PRs). I could see there stuff around maximizing issues, maximizing PRs. But maybe it's too early, it would be a too small of a scope for a GitHub label (core being it's parent).

@DanailH
Copy link
Member

DanailH commented Oct 4, 2023

@oliviertassinari good point. We can just call it [infra], although it might be difficult to differentiate [core] and [infra].

@michelengelen michelengelen deleted the 10488/revert-link branch October 4, 2023 08:12
@michelengelen
Copy link
Member Author

@DanailH @oliviertassinari IMO we could be good with just using [infra]. I dont see a particular problem differentiating this. My suggestion would be:

  • [core] is anything related to the codebase structure, e.g. packaging, general refactors, etc.
  • [infra] could be a subset of that specifically for infrastructural changes, e.g. github templates, github actions, CI, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants