Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Update prettier and pretty-quick #11735

Merged
merged 8 commits into from
Jan 24, 2024
Merged

[code-infra] Update prettier and pretty-quick #11735

merged 8 commits into from
Jan 24, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 18, 2024

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jan 18, 2024
@mui-bot
Copy link

mui-bot commented Jan 18, 2024 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Deploy preview: https://deploy-preview-11735--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b3d46bb

@Janpot Janpot marked this pull request as ready for review January 24, 2024 11:15
@Janpot Janpot requested a review from a team January 24, 2024 11:15
@Janpot Janpot changed the title Update prettier and pretty-quick [code-infra] Update prettier and pretty-quick Jan 24, 2024
michaldudak
michaldudak reviewed Jan 24, 2024
View reviewed changes
docs/data/data-grid/editing/ValidateServerNameGrid.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why these files weren't picked up by prettier before.

Copy link
Member Author

@Janpot Janpot Jan 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they were, the way anonymous functions are formatted seems to have changed in the last major.

https://prettier.io/blog/2023/07/05/3.0.0.html#dont-break-signature-of-hugged-function-expression-if-parameters-are-identifiers-without-types-13410httpsgithubcomprettierprettierpull13410-by-thorn0httpsgithubcomthorn0

michaldudak
michaldudak reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but I'll let @alexfauquette take a look.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2024
alexfauquette
alexfauquette approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. At least all I can see is formatting modification 👍

@Janpot Janpot enabled auto-merge (squash) January 24, 2024 13:50
@Janpot Janpot merged commit 76dc850 into mui:next Jan 24, 2024
15 checks passed
@Janpot Janpot deleted the pretty-quickz branch January 24, 2024 13:50
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@Janpot @thomasmoon
[code-infra] Update prettier and pretty-quick (mui#11735)
ecbeb47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak left review comments

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Janpot @mui-bot @michaldudak @alexfauquette