[TreeView] Create pro package #12240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: tree view
flaviendelangle
commented
Feb 28, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@mui/x-data-grid-pro", | |||
| "version": "7.0.0-beta.4", | |||
| "description": "The Pro plan edition of the data grid component (MUI X).", | |||
| "description": "The Pro plan edition of the Data Grid components (MUI X).", | |||
There was a problem hiding this comment.
I took the opportunity to unify all the descriptions in the README and package.json:
- I went for the "Community plan edition" wording but we can pick "Community edition" instead if you want (we had both)
- I capitalized Data Grid, Charts, Tree View and Date and Time Pickers.
- I applied plural to "Data Grid components" because "Tree View components" was also plural and we have several components on the grid with all the slots, but same I can revert to singular here if you want.
- I explicitly wrote "Pro plan edition" instead of "commercial edition" for tree view and pickers which have no premium plan.
|
Deploy preview: https://deploy-preview-12240--material-ui-x.netlify.app/ |
flaviendelangle
commented
Feb 28, 2024
| @@ -0,0 +1 @@ | |||
| export * from '@mui/x-tree-view'; | |||
There was a problem hiding this comment.
Once we actually have a pro RichTreeView component, we won't be able to export everything from the root because of name collision (same as on the grid).
But for now this simplifies a lot the PR, and it will help us make sure we don't forget some export by looking at the export JSON file.
4 tasks
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
flaviendelangle
changed the title
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #12213
TODOFollow up
@mui/x-tree-view/internalsRichTreeViewin the pro package instead of re-exporting and add license check