[charts] Improve default tooltip content #12257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
|
Deploy preview: https://deploy-preview-12257--material-ui-x.netlify.app/ |
LukasTy
previously requested changes
Feb 29, 2024
oliviertassinari
force-pushed
the
selectors-clarity
branch
from
839b093 to
c95bd98
Compare
github-actions
bot
added
the
PR: out-of-date
This comment was marked as resolved.
This comment was marked as resolved.
| <ChartsTooltipMark ownerState={{ color }} className={classes.mark} /> | ||
| <ChartsTooltipMark color={color} className={classes.mark} /> |
There was a problem hiding this comment.
I'm not sure about ownerState here.
| @@ -50,16 +50,13 @@ function DefaultChartsAxisTooltipContent(props: ChartsAxisContentProps) { | |||
| <ChartsTooltipRow key={id} className={classes.row}> | |||
| <ChartsTooltipCell className={clsx(classes.markCell, classes.cell)}> | |||
| <ChartsTooltipMark | |||
| ownerState={{ color: getColor(dataIndex) ?? color }} | |||
| boxShadow={1} | |||
There was a problem hiding this comment.
It doesn't feel like the UI should be different based on the type of tooltip. It also makes the code simpler.
Comment on lines
+9
to
13
| boxShadow: theme.shadows[1], | ||
| backgroundColor: (theme.vars || theme).palette.background.paper, | ||
| color: (theme.vars || theme).palette.text.primary, | ||
| transition: theme.transitions.create('box-shadow'), | ||
| border: `1px solid ${(theme.vars || theme).palette.divider}`, | ||
| borderRadius: theme.shape.borderRadius, |
There was a problem hiding this comment.
Get it closer to how https://mui.com/material-ui/react-paper/ feels.
Comment on lines
-61
to
+59
| // eslint-disable-next-line material-ui/no-styled-box | ||
| export const ChartsTooltipMark = styled(Box, { | ||
| export const ChartsTooltipMark = styled('div', { |
There was a problem hiding this comment.
Avoid expensive work, div is much faster than Box.
oliviertassinari
removed
the
PR: out-of-date
alexfauquette
approved these changes
Apr 23, 2024
alexfauquette
changed the title
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few opportunities I saw looking randomly at the code.