[DataGrid] Make rowCount part of the state
#12406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
component: data grid
|
Deploy preview: https://deploy-preview-12406--material-ui-x.netlify.app/ |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
oliviertassinari
force-pushed
the
master
branch
from
26ae333 to
9045cc0
Compare
1 task
MBilalShafi
changed the title
rowCount part of the state
github-actions
bot
removed
the
PR: out-of-date
romgrk
approved these changes
Apr 4, 2024
|
@MBilalShafi is there something preventing the merging of this PR? |
Not anything specific. I just wanted to wait for a specific request for backporting this one. Till now there have been no such requests which might mean people are okay with updating to v7 for this feature. But it's correct, merging it should be ok too since most of the work has been done already, I'll fix the failing tests and proceed with the merge! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #12381 from v7