-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Document interfaces for charts #12656
[docs] Document interfaces for charts #12656
Conversation
Deploy preview: https://deploy-preview-12656--material-ui-x.netlify.app/ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
{ | ||
pathname: '/x/api/charts-group', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I move the "API group" after the "Common features" because it was hard to find
{ | ||
folder: 'charts', | ||
packages: ['x-charts'], | ||
documentedInterfaces: [ | ||
'BarSeriesType', | ||
'LineSeriesType', | ||
'PieSeriesType', | ||
'ScatterSeriesType', | ||
'AxisConfig', | ||
], | ||
}, | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main modification
'bottomAxis', | ||
'topAxis', | ||
'leftAxis', | ||
'rightAxis', | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed them from the resolved types because they were too complex to be readable
I plan to add here links to ChartsXAxis
props API, but it is blocked by mui/material-ui#41950
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a minor typo
btw, do we have any docs on how these files are auto-generated and how to ignore add stuff to it? 🤔
@@ -63,6 +63,11 @@ export interface PieSeriesType<Tdata = PieValueType> extends CommonSeriesType<Td | |||
* @default 0 | |||
*/ | |||
paddingAngle?: number; | |||
/** | |||
* The sorting strategy used to oredr pie slices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo
* The sorting strategy used to oredr pie slices. | |
* The sorting strategy used to order pie slices. |
No, I recently discovered new ones. The best is to identify which script generate the files, and track back where it is executed(basically how I found the need for mui/material-ui#41950 ) For API page generation it's a bit cleaner because all our configuration is done here: https://github.com/mui/mui-x/tree/master/scripts/buildApiDocs and you can rely on TS |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
PR on top of #12653
Fix #12380
Added pages
Using
[[BarSeriesType]]
in description will generate a link to the API pageSee for example the definition of
series
props: https://deploy-preview-12656--material-ui-x.netlify.app/x/api/charts/bar-chart/#bar-chart-prop-series