[docs] Cover webpack 4 support in migration guide

[cherniavskii]

Closes #12612

Preview: https://deploy-preview-12710--material-ui-x.netlify.app/x/migration/migration-data-grid-v6/#drop-webpack-4-support

[mui-bot]

Deploy preview: https://deploy-preview-12710--material-ui-x.netlify.app/

Updated pages:

• docs/data/migration/migration-charts-v6/migration-charts-v6.md
• docs/data/migration/migration-data-grid-v6/migration-data-grid-v6.md
• docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
• docs/data/migration/migration-tree-view-v6/migration-tree-view-v6.md

Generated by 🚫 dangerJS against 1843056

[LukasTy]

Nice initiative! 👏
It's yet another section that would be a great addition to the overall v7 migration guide. 🙈
IMHO, if we keep using separate pages, then this section has to end up at least in Pickers page as well. 🤔
Technically, it makes sense in all the migration guides, but tree-view and charts might not be that relevant as there are probably close to zero users on legacy setups. 🙈

[cherniavskii]

IMHO, if we keep using separate pages, then this section has to end up at least in Pickers page as well. 🤔

Yes, I plan to add a similar section for the pickers and tree view as well.
I want to get some feedback on #12612 (comment) first.

[flaviendelangle]

Technically, it makes sense in all the migration guides, but tree-view and charts might not be that relevant as there are probably close to zero users on legacy setups.

For the Tree View is has been on the lab for years and the migration to X is super easy (more than a major from the grid probably).
So we probably have very old setups that are being migrated, just like the grid

Same for pickers

For the Charts, it's probably a lot less common since it's a brand new codebase

[cherniavskii]

Covered the Webpack 4 in all 4 migration guides: data grid, pickers, tree view and charts 👍🏻

[flaviendelangle]

I would be more explicit here. I guess nobody wants to do this to the license and the community package, they always want either to add some commercial package or skip the license.

I see 4 potential approaches:

• just add a sentence (the one I wrote is quite bad)

  Suggested change

  	+ path.resolve(__dirname, 'node_modules/@mui/x-data-grid'),
  	+ // Add all folder of each grid packages you are using.
  	+ path.resolve(__dirname, 'node_modules/@mui/x-data-grid'),

• list the 3 cases (@mui/x-data-grid | @mui/x-data-grid + @mui/x-data-grid-pro + @mui/x-license | @mui/x-data-grid + @mui/x-data-grid-pro + @mui/x-data-grid-premium | @mui/x-license)

• list all the packages but add a small // (only needed for pro and premium users) and // (only needed for pro users) after the path.resolve(...) of each commercial package.

• list all the packages even if they are not useful, I guess they do no harm and make sure people don't have nasty bugs if they buy a license in the future.

[cherniavskii]

If they only use the community package, the license package won't be installed, so there's no harm in having it there.
I would rather keep the universal snippet that would work for every plan.

[flaviendelangle]

I would rather keep the universal snippet that would work for every plan.

But do we agree that your snippet do not include the pro and premium packages and that can be problematic?
Or does node_modules/@mui/x-data-grid also match node_modules/@mui/x-data-grid-pro? In which case maybe just a comment saying that it does would be interesting.

Basically, just by reading the code snippet, the first thing I'd like to do as a pro user is to add -pro on the grid package line, and that is wrong because it will stop transpiling the community package, which is always needed.

[cherniavskii]

But do we agree that your snippet do not include the pro and premium packages and that can be problematic?
Or does node_modules/@mui/x-data-grid also match node_modules/@mui/x-data-grid-pro?

I tested the Pro and Premium packages with this snippet and it worked.
I will check again to make sure it does work, and add a comment if that's the case 👍🏻

[cherniavskii]

I confirm that @mui/x-data-grid matches all data grid packages.
I'll add a comment about that.

https://stackblitz.com/edit/mui-bug-reproduction-lkkagp?file=webpack.config.js

https://stackblitz.com/edit/mui-bug-reproduction-6xhapg?file=webpack.config.js

[LukasTy]

LGTM, apart from the open discussion. 👍

[flaviendelangle]

Thanks a lot for taking care of it!