-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Use describeTreeView
for type-ahead tests
#12811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
core
Infrastructure work going on behind the scenes
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
labels
Apr 17, 2024
flaviendelangle
changed the title
Type ahead test
[core] Use Apr 17, 2024
describeTreeView
for type-ahead tests
12 tasks
flaviendelangle
force-pushed
the
type-ahead-test
branch
2 times, most recently
from
April 17, 2024 12:03
952b8da
to
6e72b9a
Compare
Deploy preview: https://deploy-preview-12811--material-ui-x.netlify.app/ |
flaviendelangle
force-pushed
the
type-ahead-test
branch
from
April 17, 2024 12:11
6e72b9a
to
38b36c9
Compare
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 19, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 19, 2024
LukasTy
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement. 👏
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
core
Infrastructure work going on behind the scenes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12433
Blocked by #12698
I'm splitting the migration of this plugin's tests because it's basically half of the tests of the tree view 😆
I am splitting the test file into 1 describe per entry of the big
switch
inuseTreeViewKeyboardNavigation
, that way it's easy to know where a test should live. I'll see how many tests don't fit well in one of these blocks.