-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Fix group header resize #12863
Merged
cherniavskii
merged 5 commits into
mui:master
from
arminmeh:12290-fix-group-header-resize
Apr 23, 2024
Merged
[data grid] Fix group header resize #12863
cherniavskii
merged 5 commits into
mui:master
from
arminmeh:12290-fix-group-header-resize
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview: https://deploy-preview-12863--material-ui-x.netlify.app/ |
arminmeh
changed the title
12290 fix group header resize
[DataGrid] Fix group header resize
Apr 21, 2024
…ed on the flex values and the remaining space
arminmeh
force-pushed
the
12290-fix-group-header-resize
branch
from
April 21, 2024 12:40
d545e24
to
2d74526
Compare
arminmeh
force-pushed
the
12290-fix-group-header-resize
branch
from
April 22, 2024 07:49
08b15b9
to
45bd683
Compare
DanailH
added
bug 🐛
Something doesn't work
component: data grid
This is the name of the generic UI component, not the React module!
labels
Apr 22, 2024
cherniavskii
added
feature: Column groups
Related to the data grid Column groups feature
feature: Column resize
labels
Apr 22, 2024
cherniavskii
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Andrew Cherniavskii <[email protected]> Signed-off-by: Armin Mehinovic <[email protected]>
oliviertassinari
changed the title
[DataGrid] Fix group header resize
[data grid] Fix group header resize
May 24, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Andrew Cherniavskii <[email protected]>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Andrew Cherniavskii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: data grid
This is the name of the generic UI component, not the React module!
feature: Column groups
Related to the data grid Column groups feature
feature: Column resize
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12290
Recalculate group header widths after column widths were adjusted based on the flex values
Before: https://stackblitz.com/edit/react-cecf1r-nfqkhk
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-td62tk