Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Fix group header resize #12863

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Apr 21, 2024

Fix #12290

Recalculate group header widths after column widths were adjusted based on the flex values

Before: https://stackblitz.com/edit/react-cecf1r-nfqkhk
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-td62tk

@mui-bot
Copy link

mui-bot commented Apr 21, 2024

Deploy preview: https://deploy-preview-12863--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4cf98fc

@arminmeh arminmeh changed the title 12290 fix group header resize [DataGrid] Fix group header resize Apr 21, 2024
@arminmeh arminmeh force-pushed the 12290-fix-group-header-resize branch from d545e24 to 2d74526 Compare April 21, 2024 12:40
@arminmeh arminmeh force-pushed the 12290-fix-group-header-resize branch from 08b15b9 to 45bd683 Compare April 22, 2024 07:49
@DanailH DanailH added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Apr 22, 2024
@cherniavskii cherniavskii added feature: Column groups Related to the data grid Column groups feature feature: Column resize labels Apr 22, 2024
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

packages/x-data-grid/src/utils/domUtils.ts Outdated Show resolved Hide resolved
Co-authored-by: Andrew Cherniavskii <[email protected]>
Signed-off-by: Armin Mehinovic <[email protected]>
@cherniavskii cherniavskii merged commit b93315a into mui:master Apr 23, 2024
17 checks passed
@arminmeh arminmeh deleted the 12290-fix-group-header-resize branch April 23, 2024 11:13
@oliviertassinari oliviertassinari changed the title [DataGrid] Fix group header resize [data grid] Fix group header resize May 24, 2024
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Column groups Related to the data grid Column groups feature feature: Column resize
Projects
None yet
4 participants