-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Closer sync with eslint config of codebase #12864
Merged
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:code-infra-remove-dead-config
Apr 22, 2024
Merged
[code-infra] Closer sync with eslint config of codebase #12864
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:code-infra-remove-dead-config
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview: https://deploy-preview-12864--material-ui-x.netlify.app/ |
oliviertassinari
force-pushed
the
code-infra-remove-dead-config
branch
from
April 21, 2024 16:16
1d551f2
to
abb2a43
Compare
oliviertassinari
changed the title
[code-infra] Rule already in code-infra
[code-infra] Remove rule already in code-infra
Apr 21, 2024
oliviertassinari
changed the title
[code-infra] Remove rule already in code-infra
[code-infra] Remove eslint rule already in code-infra
Apr 21, 2024
oliviertassinari
force-pushed
the
code-infra-remove-dead-config
branch
4 times, most recently
from
April 21, 2024 16:18
13c9315
to
94a2fe8
Compare
oliviertassinari
force-pushed
the
code-infra-remove-dead-config
branch
from
April 21, 2024 16:18
94a2fe8
to
ebf4157
Compare
Comment on lines
-124
to
-129
{ | ||
files: ['docs/data/**/*.js', 'docs/data/**/*.tsx'], | ||
rules: { | ||
'filenames/match-exported': ['error'], | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already moved to code-infra
oliviertassinari
changed the title
[code-infra] Remove eslint rule already in code-infra
[code-infra] Closer sync with eslint config of codebase
Apr 21, 2024
LukasTy
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Infrastructure work going on behind the scenes
scope: code-infra
Specific to the core-infra product
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step to simplify the eslint config in the codebase.