Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] adjusted the code example for quickFilterValues #12919

Merged
merged 11 commits into from
Jun 4, 2024
Merged

[docs] adjusted the code example for quickFilterValues #12919

merged 11 commits into from
Jun 4, 2024

Conversation

michelengelen
Copy link
Member

adjusted the value in the code example to represent what is shown in the example
Fixes #12912

@michelengelen michelengelen added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature labels Apr 26, 2024
@michelengelen michelengelen self-assigned this Apr 26, 2024
@mui-bot
Copy link

mui-bot commented Apr 26, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12919--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 06ededf

@michelengelen michelengelen requested a review from MBilalShafi June 4, 2024 08:53
MBilalShafi
MBilalShafi approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more clear to understand now 👍

docs/data/data-grid/filtering/quick-filter.md Outdated Show resolved Hide resolved
@michelengelen @MBilalShafi
Update docs/data/data-grid/filtering/quick-filter.md
06ededf 
Co-authored-by: Bilal Shafi <[email protected]>
Signed-off-by: Michel Engelen <[email protected]>
@michelengelen michelengelen enabled auto-merge (squash) June 4, 2024 09:34
@michelengelen michelengelen merged commit 4317cf2 into mui:master Jun 4, 2024
15 checks passed
@michelengelen michelengelen deleted the docs/12912 branch June 24, 2024 07:49
This was referenced Jul 12, 2024
Merged
Merged
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@michelengelen @MBilalShafi @DungTiger
[docs] adjusted the code example for quickFilterValues (mui#12919)
5e04a22 
Signed-off-by: Michel Engelen <[email protected]>
Co-authored-by: Bilal Shafi <[email protected]>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@michelengelen @MBilalShafi @thomasmoon
[docs] adjusted the code example for quickFilterValues (mui#12919)
64fc500 
Signed-off-by: Michel Engelen <[email protected]>
Co-authored-by: Bilal Shafi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees

@michelengelen michelengelen

Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation feature: Filtering Related to the data grid Filtering feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Initialize the quick filter values -> ['quick', 'filter'] should be ['ab']
3 participants
@michelengelen @mui-bot @MBilalShafi