Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Improve TypeScript performance in PickersDay #12920

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[pickers] Improve TypeScript performance in PickersDay #12920

merged 1 commit into from
Apr 26, 2024

Conversation

flaviendelangle
Copy link
Member

Before:

image

After:

image

@flaviendelangle flaviendelangle added performance typescript component: pickers This is the name of the generic UI component, not the React module! labels Apr 26, 2024
@flaviendelangle flaviendelangle self-assigned this Apr 26, 2024
@mui-bot
Copy link

mui-bot commented Apr 26, 2024

Deploy preview: https://deploy-preview-12920--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 23297a3

LukasTy
LukasTy approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💙

michelengelen
michelengelen approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always love a short and precise improvement! 💙

@flaviendelangle flaviendelangle merged commit a61561a into mui:master Apr 26, 2024
20 checks passed
@flaviendelangle flaviendelangle deleted the perf-ts-pickersday branch April 26, 2024 14:30
@LukasTy
Copy link
Member

LukasTy commented Apr 26, 2024

@flaviendelangle @michelengelen

Visual trace representation:

Before

Screenshot 2024-04-26 at 17 39 50

After

Screenshot 2024-04-26 at 17 39 58

The two thicker left bars are AnimatedArea and BarElement.
P.S. This is for the docs package.
P.P.S. Pay attention to the top bar representing time (70s vs 50s). 👍

@LukasTy LukasTy mentioned this pull request Apr 26, 2024
Merged
@alexfauquette alexfauquette mentioned this pull request Apr 26, 2024
Closed
@Crihojames Crihojames mentioned this pull request Jun 1, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@flaviendelangle @DungTiger
[pickers] Improve TypeScript performance in PickersDay (mui#12920)
7ee5ef9
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@flaviendelangle @thomasmoon
[pickers] Improve TypeScript performance in PickersDay (mui#12920)
516f638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@LukasTy LukasTy LukasTy approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! performance typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaviendelangle @mui-bot @LukasTy @michelengelen