-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Automation: Add release PR reviewers #12982
[infra] Automation: Add release PR reviewers #12982
Conversation
Deploy preview: https://deploy-preview-12982--material-ui-x.netlify.app/ |
Co-authored-by: Jose C Quintas Jr <[email protected]> Signed-off-by: Michel Engelen <[email protected]>
# Tests that label is added on the PR | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not going to work. 🙈
Have you checked cli/cli#7671? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting ... need to look into this ... thanks for pointing it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems promissing
cli/cli#4844 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the curl approach for the API, since the gh cli seemingly does not allow for passing in an array of strings 🤷🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it might still fail as the suggestion here: cli/cli#4844 (comment) specifies the write permissions. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah ... it did fail, but for another reason! :D
I will try the new workflow with a dummy PR ... so expect notifications flying in! |
Signed-off-by: Michel Engelen <[email protected]> Co-authored-by: Jose C Quintas Jr <[email protected]>
Signed-off-by: Michel Engelen <[email protected]> Co-authored-by: Jose C Quintas Jr <[email protected]>
adds an action to automatically request reviews from the x maintainers on a release PR
cc @JCQuintas :P