[docs-infra] Fix Netlify PR preview path #12993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
scope: docs-infra
|
Deploy preview: https://deploy-preview-12993--material-ui-x.netlify.app/ |
oliviertassinari
added a commit
to mui/toolpad
that referenced
this pull request
May 4, 2024
oliviertassinari
added a commit
to mui/base-ui
that referenced
this pull request
May 4, 2024
JCQuintas
approved these changes
May 6, 2024
|
301 is the default: https://docs.netlify.com/routing/redirects/redirect-options/#http-status-codes. |
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this in #12992. Netlify PR preview JavaScript file loading is all broken 🙈:
I got this wrong in #5594. We will move these docs to subdomains anyway https://www.notion.so/mui-org/docs-infra-Change-docs-domain-0ce329e7ebc34aba8fbf4f3c5e13eb5d but it's a quick win so why not fix it as well.
Before: https://deploy-preview-12991--material-ui-x.netlify.app/x/react-data-grid/
After: https://deploy-preview-12993--material-ui-x.netlify.app/x/react-data-grid/