[pickers] Reuse AdapterDateFnsBase in Jalali adapters
#13075
Merged
+50
−315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
component: pickers
|
Deploy preview: https://deploy-preview-13075--material-ui-x.netlify.app/ |
LukasTy
commented
May 10, 2024
| @@ -49,6 +49,12 @@ import { AdapterDateFnsBase } from '../AdapterDateFnsBase'; | |||
|
|
|||
| type DateFnsLocale = typeof defaultLocale; | |||
|
|
|||
| declare module '@mui/x-date-pickers/models' { | |||
There was a problem hiding this comment.
Move declarations back to the specific adapters to allow for reuse of AdapterDateFnsBase in Jalali adapters.
LukasTy
commented
May 10, 2024
| import { AdapterFormats } from '@mui/x-date-pickers/models'; | ||
|
|
||
| describe('<AdapterDateFnsJalali />', () => { | ||
| describeJalaliAdapter(AdapterDateFnsJalali, {}); | ||
|
|
||
| describe('Adapter localization', () => { | ||
| it('Formatting', () => { | ||
| const adapter = new AdapterMomentJalaali(); | ||
| const adapter = new AdapterDateFnsJalali(); |
flaviendelangle
approved these changes
May 13, 2024
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
May 23, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #12891
AdapterDateFnsJalali.test.tsxto test proper adapterAdapterDateFnsBasein Jalali adapters