Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yarn proptypes vs pnpm proptypes #13199

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix yarn proptypes vs pnpm proptypes #13199

merged 1 commit into from
May 21, 2024

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas added bug 🐛 Something doesn't work scope: infra Org infrastructure work going on behind the scenes labels May 21, 2024
@JCQuintas JCQuintas requested a review from a team May 21, 2024 16:45
@mui-bot
Copy link

mui-bot commented May 21, 2024

Deploy preview: https://deploy-preview-13199--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e2e394b

@JCQuintas JCQuintas enabled auto-merge (squash) May 21, 2024 16:55
flaviendelangle
flaviendelangle reviewed May 21, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that those were not caught by the prop-type generation
Could you check by removing them if pnpm proptypes correctly add them back?

@JCQuintas JCQuintas merged commit ace3a3b into mui:master May 21, 2024
17 checks passed
@JCQuintas JCQuintas deleted the fix-ci-yarn-proptypes-vs-pnpm-proptypes branch May 21, 2024 17:02
@JCQuintas
Copy link
Member Author

I'm surprised that those were not caught by the prop-type generation Could you check by removing them if pnpm proptypes correctly add them back?

It correctly replaces, but the branch needs to be in sync with master, which is not always the case since we don't require them to be in sync to be able to merge.

arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request May 23, 2024
@JCQuintas
Fix yarn proptypes vs pnpm proptypes (mui#13199)
a80ea2b
@Rossen27 Rossen27 mentioned this pull request Jun 22, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@JCQuintas @DungTiger
Fix yarn proptypes vs pnpm proptypes (mui#13199)
58866fc
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@JCQuintas @thomasmoon
Fix yarn proptypes vs pnpm proptypes (mui#13199)
a6e39f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle left review comments

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JCQuintas @mui-bot @romgrk @flaviendelangle