Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve Korean (ko-KR) locale #13452

Merged
merged 2 commits into from
Jun 13, 2024
Merged

[l10n] Improve Korean (ko-KR) locale #13452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5cf10c
change 'meridiem' to '오전/오후를'
ryxxn Jun 11, 2024
5f10b6d
change hoursClockNumberText from 'hh시간' to 'hh시'
ryxxn Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/x-date-pickers/src/locales/koKR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const views: Record<TimeViewWithMeridiem, string> = {
hours: '시간을',
minutes: '분을',
seconds: '초를',
meridiem: '메리디엠',
meridiem: '오전/오후를',
};

const koKRPickers: Partial<PickersLocaleText<any>> = {
Expand Down Expand Up @@ -45,7 +45,7 @@ const koKRPickers: Partial<PickersLocaleText<any>> = {
// Clock labels
clockLabelText: (view, time, adapter) =>
`${views[view]} 선택하세요. ${time === null ? '시간을 선택하지 않았습니다.' : `현재 선택된 시간은 ${adapter.format(time, 'fullTime')}입니다.`}`,
hoursClockNumberText: (hours) => `${hours}시간`,
hoursClockNumberText: (hours) => `${hours}시`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this change?
Given Google Translate the difference is as follows:
10 hours -> 10 o'clock, is it expected?
In English, we also didn't use o'clock, because it could be misinterpreted.
O'clock means—exactly that hour/time, but in this case, it might often not be the case as this is a label for only the hours section/part on the TimeClock or MultiSectionDigitalClock.

Can you confirm if the expectation in Korean is different than in English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand and appreciate your concerns regarding the use of "o'clock."
Just as "o'clock" in English signifies an exact time, specifically the top of the hour, the Korean equivalent "시" serves a similar yet slightly different role in time selection.

  • In English, o'clock:

    • Precisely refers to a specific time. For example: "10 o'clock" means exactly 10:00 AM or 10:00 PM.
    • Implies that the user must select an exact hour.
    • However, using o'clock in a time selection tool might lead to the misconception that users cannot set minutes or seconds in addition to the hour.

  • In Korean, 시:

    • Similarly refers to a specific time but is more flexible. For example: "10시" can mean 10 o'clock, but users naturally understand that they can also adjust the minutes and seconds.
    • For example, "10:03" in Korean is expressed as "10시 3분," which clearly indicates a specific time.
    • This allows users to easily understand and set hours, minutes, and seconds.

Example of 10:03

  • In English:

    • The expression "10 o'clock and 3 minutes" is not used.
    • Instead, we say "10:03 AM" or "10 oh three in the morning."

  • In Korean:

    • The expression "10시 3분" is commonly used.
    • This means exactly 10:03 AM.

In this context, using "시" in the Korean UI is an effective way to provide users with a clear option to select a time within that hour range, thus minimizing confusion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a detailed explanation! 🙏
It was a nice "language school day". 👍

minutesClockNumberText: (minutes) => `${minutes}분`,
secondsClockNumberText: (seconds) => `${seconds}초`,

Expand Down
Loading