-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add eslint rule to restrict import from ../internals
root
#13633
[core] Add eslint rule to restrict import from ../internals
root
#13633
Conversation
Deploy preview: https://deploy-preview-13633--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for charts. I let others say if they want the rule applied to their packages too
100% in favor of doing it for the Tree View and the Pickers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change. 💯
I think that it would be a nice improvement to other packages as well. 👍
@LukasTy @flaviendelangle added the treeview and pickers packages as well, let me know if the adapted code is correct 😅 |
Following the discussion in #13562 where valid points were raised regarding folder structure and our own conventions, it made more sense to address the actual issue in the charts codebase, where the
../internals
root is sometimes automatically imported by the IDE, which has a high probability of causing cyclic imports.All packages?
This rule be updated to prevent this issue for all packages if needed.
Main issues when using on all our packages.