Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add MUI Internal renovate group #13846

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jul 15, 2024

I've noticed that the internal packages are being released frequently and they trigger a lot of CI runtime even for these packages.
Screenshot 2024-07-15 at 15 18 19

Grouping them together should reduce the CI effort.
Seeing the below case was the final "ding-ding" moment:
Screenshot 2024-07-15 at 15 17 02
When we have separate bump PR: #13830.

WDYT @mui/code-infra, should we add @mui/docs to this group or MUI Core?

mui-x/renovate.json

Lines 82 to 91 in 29aeeb8

"groupName": "MUI Core",
"matchPackageNames": [
"@mui/base",
"@mui/icons-material",
"@mui/lab",
"@mui/material",
"@mui/styles",
"@mui/system",
"@mui/utils"
]

@LukasTy LukasTy added core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product labels Jul 15, 2024
@LukasTy LukasTy requested review from a team July 15, 2024 12:20
@LukasTy LukasTy self-assigned this Jul 15, 2024
@mui-bot
Copy link

mui-bot commented Jul 15, 2024

Deploy preview: https://deploy-preview-13846--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a564c02

@Janpot
Copy link
Member

Janpot commented Jul 16, 2024

WDYT @mui/code-infra, should we add @mui/docs to this group or MUI Core?

I think we can treat it as an internal package. In practice it will follow the monorepo dependency still for a while.

@LukasTy
Copy link
Member Author

LukasTy commented Jul 16, 2024

I think we can treat it as an internal package. In practice it will follow the monorepo dependency still for a while.

Thanks for the clarification. 🙏
I've added it to the MUI Internal group. 😉

@LukasTy LukasTy enabled auto-merge (squash) July 16, 2024 07:36
@LukasTy LukasTy merged commit 7939087 into mui:master Jul 16, 2024
15 checks passed
@LukasTy LukasTy deleted the optimize-renovate-for-mui-internal branch July 16, 2024 07:55
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants