[fields] Prevent keyboard editing when disabled #13900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-13900--material-ui-x.netlify.app/ |
DanailH
changed the title
DanailH
added
bug 🐛
LukasTy
changed the title
LukasTy
added
the
feature: Keyboard editing
LukasTy
reviewed
Jul 19, 2024
There was a problem hiding this comment.
Great job! 👏
Thanks for taking care of it. 🙏
Could you add at least a few tests for v7 fields (with enableAccessibleFieldDOMStructure) keyboard editing when disabled? 🙏
Source: #13387 (comment)
packages/x-date-pickers/src/internals/hooks/useField/useFieldV6TextField.ts
Show resolved
Hide resolved
packages/x-date-pickers/src/internals/hooks/useField/useFieldV6TextField.ts
Outdated
Show resolved
Hide resolved
arthurbalduini
force-pushed
the
prevents-disabled-field-editing
branch
from
a8c30aa to
e27abf6
Compare
added 2 commits
July 19, 2024 15:26
arthurbalduini
commented
Jul 19, 2024
packages/x-date-pickers/src/DateField/tests/editing.DateField.test.tsx
Outdated
Show resolved
Hide resolved
arthurbalduini
commented
Jul 19, 2024
| @@ -744,6 +744,63 @@ describe('<DateField /> - Editing', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describeAdapters('Disabled field', DateField, ({ renderWithProps }) => { | |||
There was a problem hiding this comment.
Do you see a good reason to implement similar tests for TimeField ?
Or maybe test it elsewhere?
There was a problem hiding this comment.
Good point, I agree, there is no need to duplicate the tests on other regular Field components. 👍
LukasTy
approved these changes
Jul 22, 2024
| @@ -744,6 +744,63 @@ describe('<DateField /> - Editing', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describeAdapters('Disabled field', DateField, ({ renderWithProps }) => { | |||
There was a problem hiding this comment.
Good point, I agree, there is no need to duplicate the tests on other regular Field components. 👍
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Arthur Balduini <[email protected]>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Arthur Balduini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13387