[DateTimeRangePicker] Fix date format resolving from views on 24hr locales #14341
Conversation
arthurbalduini
added
the
component: pickers
|
Deploy preview: https://deploy-preview-14341--material-ui-x.netlify.app/ |
arthurbalduini
force-pushed
the
date-time/fix-date-format-resolver
branch
from
0dbc59a to
dbddcbf
Compare
arthurbalduini
changed the title
DateTimePickersDateTimeRangePickers
arthurbalduini
changed the title
DateTimeRangePickersDateTimeRangePickers
arthurbalduini
changed the title
DateTimeRangePickersDateTimeRangePickers
dosubot
bot
added
the
size:S
| @@ -30,7 +35,7 @@ export const resolveDateTimeFormat = <TDate extends PickerValidDate>( | |||
| views.forEach((view) => { | |||
| if (isTimeView(view)) { | |||
| timeViews.push(view as TimeView); | |||
| } else { | |||
| } else if (isDatePickerView(view)) { | |||
There was a problem hiding this comment.
The problem was an oversight that we did not exclude meridiem view, which caused resolveDateFormat to always return keyboardDate in case of a locale with 12h clock.
On 24h clock the behavior was "correct".
I've adjusted the code to avoid this inconsistency and also added an exception to not resolve dateFormat on DateTimeRange pickers as they do not have different date views other than day for now.
LukasTy
added
component: DateTimeRangePicker
LukasTy
changed the title
DateTimeRangePickers
I assumed that veryfing if the value is an array (date range) would be more clear than adding a new parameter to the function to be used only in DateTimePickers, since the view verification was done in |
Fixes #14334.
For
DateTimeRangePickersthe ["day"] case returns an incorrect format.