Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Apply default properties if they are not passed in a reorder column #14473

Merged
merged 5 commits into from
Nov 7, 2024
Merged

[DataGridPro] Apply default properties if they are not passed in a reorder column #14473

merged 5 commits into from
Nov 7, 2024

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Sep 4, 2024 •
edited
Loading

@k-rajat19 k-rajat19 mentioned this pull request Sep 4, 2024
Closed
1 task
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Sep 5, 2024
@mui-bot
Copy link

mui-bot commented Sep 17, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14473--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e83cb6a

@k-rajat19
Copy link
Contributor Author

@MBilalShafi can you review these changes? this will not take much time as these are very small changes :)

@k-rajat19
Copy link
Contributor Author

Hi @MBilalShafi,
can we merge these changes, let me know if I missed something

@MBilalShafi
Copy link
Member

MBilalShafi commented Sep 30, 2024 •
edited
Loading

Hey @k-rajat19,

Apologies for the delay. I'll take a look at the PR in a while.

@oliviertassinari oliviertassinari changed the title [DataGridPro] apply default properties if they are not passed in a reorder column [DataGridPro] Apply default properties if they are not passed in a reorder column Oct 1, 2024
@zannager zannager requested a review from MBilalShafi October 17, 2024 12:05
@k-rajat19
Copy link
Contributor Author

Hi @MBilalShafi ,
Are there any plans to merge this?

MBilalShafi
MBilalShafi approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work feature: Reordering Related to the data grid Reordering feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Nov 7, 2024
@MBilalShafi MBilalShafi enabled auto-merge (squash) November 7, 2024 11:38
@MBilalShafi MBilalShafi merged commit c8418e2 into mui:master Nov 7, 2024
24 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
@k-rajat19 @MBilalShafi @web-flow
[DataGridPro] Apply default properties if they are not passed in a re…
49c9a45 
…order column (#14473)

Co-authored-by: Bilal Shafi <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Merged
@k-rajat19 k-rajat19 deleted the reorder-classes branch November 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Reordering Related to the data grid Reordering feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Custom Row Reorder Column Definition omits built-in CSS Classes
4 participants
@k-rajat19 @mui-bot @MBilalShafi @zannager