[TreeView] Apply experimental features in getDefaultizedParams instead of in the plugin render
#14661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: tree view
…d of in the plugin render
flaviendelangle
force-pushed
the
experimental-feature-getDefaultizedParams
branch
from
f346b49 to
174c660
Compare
|
Deploy preview: https://deploy-preview-14661--material-ui-x.netlify.app/ Updated pages: |
18 tasks
noraleonte
approved these changes
Sep 25, 2024
| @@ -54,10 +54,16 @@ export const extractPluginParamsFromProps = < | |||
| } | |||
| }); | |||
|
|
|||
| const cleanExperimentalFeatures = | |||
There was a problem hiding this comment.
Super nitpick: cleanExperimentalFeatures sounds a bit weird.. I get why it's called that, and I also don't have a better idea for what to call it, so I guess it's fine. 😅
There was a problem hiding this comment.
Changed from experimentalFeatures => cleanExperimentalFeatures to inExperimentalFeatures => experimentalFeatures
flaviendelangle
deleted the
experimental-feature-getDefaultizedParams
branch
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
…ead of in the plugin render (mui#14661)
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #14210 (first of a long list 😆 )
In #14210 I try to get rid of
instance.isTreeViewEditable(becauseinstancecan only contain stuff that do not need to trigger a re-render of items when it changes). Instead I'm using theisItemEditableparam directly (both in items and in plugins depending onuseTreeViewLabel).The easiest solution I found was to apply the default value of
isItemEditableingetDefaultizedParamsand to throw the error there when the experimental feature is not set.