Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add 'onColumnHeaderContextMenu' event #14734

Merged
merged 7 commits into from
Oct 8, 2024
Merged

[DataGrid] Add 'onColumnHeaderContextMenu' event #14734

merged 7 commits into from
Oct 8, 2024

Conversation

vfbiby
Copy link
Contributor

@vfbiby vfbiby commented Sep 26, 2024

@mui-bot
Copy link

mui-bot commented Sep 26, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14734--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c81f2f8

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Sep 26, 2024
@vfbiby
Copy link
Contributor Author

vfbiby commented Oct 3, 2024

hi, all ci test pass, please give a review and let it merge!

cherniavskii
cherniavskii reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

packages/x-data-grid/src/models/events/gridEventLookup.ts Outdated Show resolved Hide resolved
packages/x-data-grid/src/models/props/DataGridProps.ts Outdated Show resolved Hide resolved
packages/x-data-grid/src/models/props/DataGridProps.ts Outdated Show resolved Hide resolved
@vfbiby
Copy link
Contributor Author

vfbiby commented Oct 4, 2024

@cherniavskii hi, every thing looks ok

@cherniavskii cherniavskii added the enhancement This is not a bug, nor a new feature label Oct 8, 2024
@cherniavskii cherniavskii merged commit 3d7acb1 into mui:master Oct 8, 2024
20 checks passed
@DMPatod DMPatod mentioned this pull request Nov 2, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Nov 5, 2024
Merged
This was referenced Nov 8, 2024
Open
Open
Open
@trbagley-gresham trbagley-gresham mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vfbiby @mui-bot @cherniavskii @zannager