[DataGrid] Pass rowId param to processRowUpdate
#14821
Conversation
|
Deploy preview: https://deploy-preview-14821--material-ui-x.netlify.app/ Updated pages: |
| * @returns {Promise<R> | R} The final values to update the row. | ||
| */ | ||
| processRowUpdate?: (newRow: R, oldRow: R) => Promise<R> | R; | ||
| processRowUpdate?: (newRow: R, oldRow: R, rowId?: GridRowId) => Promise<R> | R; |
There was a problem hiding this comment.
Why optional though? It seems that we can guarantee rowId presence.
There was a problem hiding this comment.
How can I update api in docs, I am running pnpm docs:api but it is not updating files ?
| * @returns {Promise<R> | R} The final values to update the row. | ||
| */ | ||
| processRowUpdate?: (newRow: R, oldRow: R) => Promise<R> | R; | ||
| processRowUpdate?: (newRow: R, oldRow: R, rowId: GridRowId) => Promise<R> | R; |
There was a problem hiding this comment.
Not a huge fan of having 3 flat params with no apparent hierarchy.
If the method is not super frequently called, maybe putting the id in a additionalParams object would make sure that we stick with 3 params even if we have more info to pass to this function in the future.
There was a problem hiding this comment.
thanks for the suggestion
the method is called on stop editing and copy paste, I think we should implement this change.
zannager
added
the
component: data grid
cherniavskii
added
feature: Editing
Resolves #13381
This PR adds a third parameter
rowIdtoprocessRowUpdatemethod. However, one can useapiRef.current.getRowIdto retrieve the id of the row. Still, the more reliable and efficient approach is to pass row id as a parameter as @cherniavskii mentioned here.By doing so, one can opt out of adding
apiRefto the dependency array inuseCallback, which may improve performance if the method is expensive.