[test] Restore "pnpm tc" CLI #14852
Merged
[test] Restore "pnpm tc" CLI #14852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-14852--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Oct 7, 2024
oliviertassinari
changed the title
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that
pnpm tc test-suitewas broken working on #14851. After this change this now behaves as before, for example, say I want to run those tests:mui-x/packages/x-data-grid/src/tests/rowSpanning.DataGrid.test.tsx
Line 9 in 5260148
Screen.Recording.2024-10-06.at.20.10.07.mov
I don't know how you guys managed without it. It's so much faster to run. Now, to be fair, those tests need to run in Karma, so not very helpful 😄. Anyway, restoring back to match the main repository. I guess with Vitest, we can use the same pattern.
This changed with #14852.