-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data grid] Fix excessive white space at the end of grid #14864
Conversation
Deploy preview: https://deploy-preview-14864--material-ui-x.netlify.app/ |
31349f8
to
c3f8f1e
Compare
@romgrk can you please look at these changes when you have time? |
Did you have a reproduction case to test this with? Could you share it here in a codesandbox? You can fork a codesandbox from any example from the docs in the deploy for this PR. |
@romgrk it is replicable on the docs https://mui.com/x/react-data-grid/demo/. |
Where in the docs? |
screen-capture.1.webmrecording for reference |
I can't reproduce on chrome/linux with the demo in that recording, although I can reproduce the original issue at https://mui.com/material-ui/getting-started/templates/dashboard/. Is there a way you could isolate the issue on the template dashboard and put it in a codesandbox? The code change makes sense, but I don't have a way to test that the issue is fixed. |
@romgrk please find the codesandbox link for template dashboard with fix https://codesandbox.io/p/sandbox/cranky-river-zvdr3t?from-embed=&workspaceId=da680cdb-77a3-4ab2-8045-3eb83f570a91. I've published the data-grid packages to my personal npm (will delete them once this testing is completed). |
@cherniavskii @romgrk I don't have write access, can you please help merge the PR |
This PR is created to address #14816
Unable to attach labels to the PR, can someone please help with attaching the component: data grid & bug & docs labels