Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data grid] Fix excessive white space at the end of grid #14864

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

kalyan90
Copy link
Contributor

@kalyan90 kalyan90 commented Oct 7, 2024

This PR is created to address #14816

Unable to attach labels to the PR, can someone please help with attaching the component: data grid & bug & docs labels

@kalyan90 kalyan90 marked this pull request as ready for review October 7, 2024 19:00
@romgrk romgrk added component: data grid This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Oct 7, 2024
@romgrk romgrk self-requested a review October 7, 2024 19:53
@mui-bot
Copy link

mui-bot commented Oct 7, 2024

Deploy preview: https://deploy-preview-14864--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 9c569bb

@kalyan90 kalyan90 force-pushed the fix-excessive-white-space branch from 31349f8 to c3f8f1e Compare October 9, 2024 02:43
@kalyan90
Copy link
Contributor Author

@romgrk can you please look at these changes when you have time?

@romgrk
Copy link
Contributor

romgrk commented Oct 10, 2024

Did you have a reproduction case to test this with? Could you share it here in a codesandbox? You can fork a codesandbox from any example from the docs in the deploy for this PR.

@kalyan90
Copy link
Contributor Author

@romgrk it is replicable on the docs https://mui.com/x/react-data-grid/demo/.
Also argos CI step was failing please help with that

@romgrk
Copy link
Contributor

romgrk commented Oct 10, 2024

Where in the docs?

@kalyan90
Copy link
Contributor Author

kalyan90 commented Oct 11, 2024

screen-capture.1.webm

recording for reference

@romgrk
Copy link
Contributor

romgrk commented Oct 11, 2024

I can't reproduce on chrome/linux with the demo in that recording, although I can reproduce the original issue at https://mui.com/material-ui/getting-started/templates/dashboard/.

Is there a way you could isolate the issue on the template dashboard and put it in a codesandbox? The code change makes sense, but I don't have a way to test that the issue is fixed.
Alternatively, maybe someone else on macOS can reproduce the issue @mui/xgrid?

@kalyan90
Copy link
Contributor Author

kalyan90 commented Oct 13, 2024

@romgrk please find the codesandbox link for template dashboard with fix https://codesandbox.io/p/sandbox/cranky-river-zvdr3t?from-embed=&workspaceId=da680cdb-77a3-4ab2-8045-3eb83f570a91. I've published the data-grid packages to my personal npm (will delete them once this testing is completed).

@kalyan90
Copy link
Contributor Author

@cherniavskii @romgrk I don't have write access, can you please help merge the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants