Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Fix hydration error #15002

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Oct 17, 2024

Fixes #14980
Extracted from #14210

Only sets the default id attribute after the hydration, like useId does

@flaviendelangle flaviendelangle self-assigned this Oct 17, 2024
@flaviendelangle flaviendelangle marked this pull request as draft October 17, 2024 09:02
@flaviendelangle flaviendelangle added regression A bug, but worse component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Oct 17, 2024
@mui-bot
Copy link

mui-bot commented Oct 17, 2024

Deploy preview: https://deploy-preview-15002--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 68456d2

@flaviendelangle flaviendelangle marked this pull request as ready for review October 17, 2024 09:09
@flaviendelangle flaviendelangle mentioned this pull request Oct 17, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

…seTreeViewId.ts

Co-authored-by: Lukas Tyla <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TreeView] Hydration error from 7.19.0 onwards
3 participants