Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integration test in CI #151

Closed
wants to merge 11 commits into from
Closed

add integration test in CI #151

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7e6a843
add integration test in CI
dtassone Aug 5, 2020
9ac485f
fix yarn script
dtassone Aug 5, 2020
23dbafb
fix integration test ci
dtassone Aug 5, 2020
7a283a7
rename test step
dtassone Aug 5, 2020
d913ed7
refactor test to use only 1 browser
dtassone Aug 5, 2020
82f148c
prettier
dtassone Aug 5, 2020
a6bfaf0
eslint
dtassone Aug 5, 2020
8a0296a
add store-artifacts for diff-output
dtassone Aug 5, 2020
e52f8b7
testing pptr args to render font properly
dtassone Aug 6, 2020
deff3e7
update screenshot with monospace font override
dtassone Aug 6, 2020
22d8b0c
attempting to integrate docker to our local pptr tests
dtassone Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,14 @@ jobs:
# hardcoded in karma-webpack
path: /tmp/_karma_webpack_
destination: artifact-file
test_integration:
dtassone marked this conversation as resolved.
Show resolved Hide resolved
<<: *defaults
steps:
- checkout
- install_js
- run:
name: 'Running Storybook integration tests'
command: yarn e2e
workflows:
version: 2
pipeline:
Expand All @@ -117,3 +125,6 @@ workflows:
- test_browser:
requires:
- checkout
- test_integration:
requires:
- checkout
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
"test:karma": "cross-env NODE_ENV=test karma start test/karma.conf.js",
"test:unit": "cross-env NODE_ENV=test mocha 'packages/**/*.test.tsx' --exclude '**/node_modules/**'",
"test:watch": "yarn test:unit --watch",
"test:e2e": "cd packages/storybook && yarn test:ci",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering storybook is a workspace?

Suggested change
"test:e2e": "cd packages/storybook && yarn test:ci",
"test:e2e": "yarn workspace storybook test:ci",

"lint": "yarn eslint && yarn jsonlint",
"eslint": "eslint . --cache --report-unused-disable-directives --ext .js,.ts,.tsx",
"eslint:ci": "eslint . --report-unused-disable-directives --ext .js,.ts,.tsx"
Expand Down