Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Add name attribute to selection checkboxes #15178

Merged
merged 10 commits into from
Dec 30, 2024
Merged

[DataGrid] Add name attribute to selection checkboxes #15178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9f47f22
Add id to GridCellCheckboxRenderer and GridHeaderCheckbox
derek-0000 Oct 29, 2024
10b32c9
Merge branch 'master' into add-id-checkbox-cell
derek-0000 Nov 7, 2024
4ea88e4
Merge branch 'master' into add-id-checkbox-cell
derek-0000 Nov 11, 2024
6f16e36
Merge branch 'master' into add-id-checkbox-cell
derek-0000 Nov 11, 2024
f75e131
Merge branch 'master' into add-id-checkbox-cell
derek-0000 Nov 22, 2024
5bfd211
Merge branch 'master' of https://github.com/mui/mui-x into add-id-che…
derek-0000 Nov 27, 2024
7fe300e
Merge branch 'master' into add-id-checkbox-cell
derek-0000 Dec 13, 2024
ba6478e
reduce the diff
cherniavskii Dec 13, 2024
0146654
use name instead of id
cherniavskii Dec 13, 2024
56d453e
Merge branch 'master' into add-id-checkbox-cell
derek-0000 Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/x-data-grid/src/components/columnSelection/GridCellCheckboxRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const GridCellCheckboxForwardRef = forwardRef<HTMLInputElement, GridRenderCellPa
checked={isChecked && !isIndeterminate}
onChange={handleChange}
className={classes.root}
inputProps={{ 'aria-label': label }}
inputProps={{ 'aria-label': label, name: 'select_row' }}
onKeyDown={handleKeyDown}
indeterminate={isIndeterminate}
disabled={!isSelectable}
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid/src/components/columnSelection/GridHeaderCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ const GridHeaderCheckbox = forwardRef<HTMLButtonElement, GridColumnHeaderParams>
checked={isChecked && !isIndeterminate}
onChange={handleChange}
className={classes.root}
inputProps={{ 'aria-label': label }}
inputProps={{ 'aria-label': label, name: 'select_all_rows' }}
tabIndex={tabIndex}
onKeyDown={handleKeyDown}
disabled={!isMultipleRowSelectionEnabled(rootProps)}
Expand Down
Loading