[DataGrid] Inject default Col Def values before updating the column state #15366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-rajat19
changed the title
|
Deploy preview: https://deploy-preview-15366--material-ui-x.netlify.app/ |
oliviertassinari
added
the
component: data grid
k-rajat19
commented
Nov 14, 2024
| @@ -380,7 +380,13 @@ export const createColumnsState = ({ | |||
| } | |||
| }); | |||
|
|
|||
| columnsState.lookup[field] = resolveProps(existingState, { ...newColumn, hasBeenResized }); | |||
| const newColumnWithDefaultValues = resolveProps(defaultColTypeDef, newColumn); | |||
There was a problem hiding this comment.
|
@romgrk moving #15317 (comment) here, looking at this PR changes, I'm not sure we can extract logic to helper function as changes seems to be context dependent, wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15317
Before: https://stackblitz.com/edit/github-3rk5go-nd8osk?file=src%2Fdemo.tsx
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-m49n6j
Fixes #14446
Before: https://codesandbox.io/p/sandbox/wispy-paper-mfjzqs?file=%2Fsrc%2FDemo.tsx%3A1%2C1-23%2C1
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-4lk7v4
Change done in #14456 is a bit misleading,
existingStatedoes not contains default col def values rather it contains the default values which are overridden by the values passed in a column prop.Closes #15409