[DataGridPremium] Namespace Excel export worker #16020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
|
Deploy preview: https://deploy-preview-16020--material-ui-x.netlify.app/ |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cherniavskii
changed the title
cherniavskii
added
needs cherry-pick
cherniavskii
force-pushed
the
worker-namespace
branch
from
aee17e8 to
7138f2f
Compare
github-actions
bot
removed
the
PR: out-of-date
cherniavskii
approved these changes
Feb 11, 2025
|
Cherry-pick PRs will be created targeting branches: v7.x |
|
Ah, I had forgotten about those. I have open like 40 PRs during the chrismas break but I had no time to work on those since. Thanks |
Very productive holidays! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic looks wrong. Workers share the same pub-sub channel namespace. I believe it's why, e.g. https://revealjs.com/postmessage/ has a
namespaceproperty. You can reproduce a conflict by runningand opening the page:
I don't know how to write a test for this effectively, so I skipped it. I initially noticed this improving slightly the visual regression flow in Material UI, saw an error in the console, which shouldn't be there.
Preview: https://deploy-preview-16020--material-ui-x.netlify.app/x/react-data-grid/export/#using-a-web-worker