Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Refactor: create base Checkbox #16445

Merged
merged 12 commits into from
Feb 11, 2025

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Feb 4, 2025

Part of the design-system agnostic work.

Create the base Checkbox. Unlike the material-ui one, this one handles its own label the same way the base TextField does.

@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Feb 4, 2025
@romgrk romgrk requested a review from a team February 4, 2025 02:29
@mui-bot
Copy link

mui-bot commented Feb 4, 2025

Deploy preview: https://deploy-preview-16445--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7c41e72

Copy link

github-actions bot commented Feb 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 7, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 7, 2025
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@romgrk romgrk merged commit 2372cf8 into mui:master Feb 11, 2025
18 checks passed
@romgrk romgrk deleted the refactor-agnostic-checkbox branch February 11, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants