[charts] Propagate the axis scale to the valueFormatter
#16555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-16555--material-ui-x.netlify.app/ Updated pages: |
bernardobelchior
approved these changes
Feb 12, 2025
alexfauquette
added
the
component: charts
alexfauquette
changed the title
valueFormatter
CodSpeed Performance ReportMerging #16555 will not alter performanceComparing Summary
|
JCQuintas
reviewed
Feb 13, 2025
Comment on lines
+38
to
+43
| const d3Text = ( | ||
| context.scale as ScaleLogarithmic<number, number, never> | ||
| ).tickFormat( | ||
| 30, | ||
| 'e', | ||
| )(f); |
There was a problem hiding this comment.
😭 I tried to fix this typing, but there are too many generics 😆
Technically it should be possible to use the correct type based on the scaleType: 'log'. But due to how our generics are setup and the usage/initialization/direct-override of the types everywhere, typescript can't automatically deduce the types
JCQuintas
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16350
I did not propagate the scale to the legend formatter, because in such case, it's not clear is it's the axis scale, or the color-scale to pass. And not that much usefull.