[charts] Fix default label measurement being off #16635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-16635--material-ui-x.netlify.app/ |
bernardobelchior
force-pushed
the
fix-tick-label-measurement
branch
from
9d0c9c0 to
4cd069d
Compare
bernardobelchior
added
the
component: charts
CodSpeed Performance ReportMerging #16635 will not alter performanceComparing Summary
|
bernardobelchior
force-pushed
the
fix-tick-label-measurement
branch
from
6c5bd42 to
7c866a9
Compare
bernardobelchior
force-pushed
the
fix-tick-label-measurement
branch
from
7c866a9 to
a972c32
Compare
alexfauquette
approved these changes
Feb 18, 2025
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Bernardo Belchior <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix default label measurement being off by a few pixels. This happened because the text style was being applied through a class, but we only take inline styles into account when measuring the labels' size. This PR fixes the issue by applying the text styles as inline styles.
It also adds a caveat in the docs that applying text styles through classes may result in overlaps:
Please let me know if this kind of warning content and style is acceptable within the docs.