Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix charts with on bar and line pages #16712

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

@alexfauquette alexfauquette added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Feb 24, 2025
@mui-bot
Copy link

mui-bot commented Feb 24, 2025

Deploy preview: https://deploy-preview-16712--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c067b4d

Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #16712 will not alter performance

Comparing alexfauquette:fix-width (c067b4d) with master (c871c5e)

Summary

✅ 6 untouched benchmarks

Comment on lines +24 to +25
min: new Date(1990, 0, 1),
max: new Date(2018, 0, 1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this necessary? 🤔

Copy link
Member Author

@alexfauquette alexfauquette Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile D3 uses one tick every 10 years instaed of every 2 or 4 years. So the end date is 2020 leving 2 years without data at the end. For me it looks better with the area finishing at the end of the axis

image

image

@alexfauquette alexfauquette merged commit 975b888 into mui:master Feb 25, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants