[XGrid] Close column header menu when resizing column #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not find tests about this menu so I created a new file |
dtassone
suggested changes
Jun 30, 2021
packages/grid/_modules_/grid/hooks/features/columnResize/useGridColumnResize.tsx
Outdated
Show resolved
Hide resolved
dtassone
reviewed
Jun 30, 2021
m4theushw
reviewed
Jul 1, 2021
packages/grid/_modules_/grid/hooks/features/columnResize/useGridColumnResize.tsx
Outdated
Show resolved
Hide resolved
2 tasks
dtassone
approved these changes
Jul 5, 2021
dtassone
reviewed
Jul 5, 2021
packages/grid/_modules_/grid/hooks/features/columnResize/useGridColumnResize.tsx
Outdated
Show resolved
Hide resolved
m4theushw
reviewed
Jul 6, 2021
oliviertassinari
approved these changes
Jul 6, 2021
|
|
||
| const separator = columnCell.querySelector('.MuiDataGrid-iconSeparator'); | ||
| fireEvent.mouseDown(separator); | ||
| // TODO remove mouseUp once useGridColumnReorder will handle cleanup properly |
There was a problem hiding this comment.
We will likely get this for free with a fix of #2007.
| const menuIconButton = columnWithMenuCell.querySelector('button[aria-label="Menu"]'); | ||
|
|
||
| fireEvent.click(menuIconButton); | ||
| await waitFor(() => expect(screen.queryByRole('menu')).not.to.equal(null)); |
There was a problem hiding this comment.
Ideally, we wouldn't need for an await but it's not obvious how we could make it happen. Maybe we would need to disable the transition in the render factory helper, or to mock the time. I'm raising the point because await often lead to slower and less reliable tests. Anyway, not a blocker.
There was a problem hiding this comment.
I'm also in favor of fixing this behavior in a later PR to avoid blocking this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1931
Preview: https://deploy-preview-1989--material-ui-x.netlify.app/components/data-grid/columns/#resizing