Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Support style prop #2116

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

oliviertassinari
Copy link
Member

If we support the className prop, then it makes sense to support the style prop too. I got trapped in mui/material-ui#27196.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request labels Jul 10, 2021
);

// @ts-expect-error need to migrate helpers to TypeScript
expect(document.querySelector('.MuiDataGrid-root')).toHaveInlineStyle({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't use the role="grid" because I trust more that we set the root class name on the root than the aria.

@oliviertassinari oliviertassinari merged commit 2a8530e into mui:master Jul 12, 2021
@oliviertassinari oliviertassinari deleted the fix-style-support branch July 12, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants