-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Drop support of v4 below 4.12.0
#2281
Conversation
...(lookup[item.columnField!] && ( | ||
<li key={item.id}> | ||
<li key={index}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for reverting this change that Damien did recently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So keep that change right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap
4.12.0
…taGrid-batch-docs-fixes
It looks great. I think that we can keep the logic that supports < v4.12.0 as long as the overhead for us is low, it seems to be the case, so far. |
Found some errors being thrown in the console on some pages in the docs. This PR aims to fix those.
The main one is the deprecated
createMuiTheme
and since the docs use the latest version of the core this results in errors in the console.The other one is an error related to having
key
being passed to theGridToolbarFilterButton
.Closes #2309
Breaking changes
Drop support of v4 below
"@material-ui/core": "4.12.0"