v4.0.1 #2733
v4.0.1 #2733
Conversation
m4theushw
requested review from
DanailH,
oliviertassinari and
flaviendelangle
CHANGELOG.md
Outdated
|
|
||
| _Sep 29, 2021_ | ||
|
|
||
| This version includes bugfixes and features already released in v5.x. |
There was a problem hiding this comment.
Would it help to frame the message as, v5 is active, and we have cherry-picked what we could from it to the legacy v4 version?
| This version includes bugfixes and features already released in v5.x. | |
| This version backports bug fixes and features from the v5.x active release line. |
There was a problem hiding this comment.
Should we make clear that might not have other v4 releases due to the complexity of cherry-picking?
| This version includes bugfixes and features already released in v5.x. | |
| This version backports bug fixes and some of the features from the v5.x active release line. | |
| As the development of v5 evolves, newer fixes might not be cherry-picked to the legacy version. | |
| To have access to the latest features it is encouraged to upgrade to MUI X v5 and MUI Core v5. |
I created a CodeSandbox using MUI Core v4 and v5 and it seems to work fine. The only drawback is having to install both versions, but the benefit of getting new features pays off, I think. We could add a section to the docs explaining how to configure the prefixes.
There was a problem hiding this comment.
Yeah, agree, a section in the docs about how to use MUI Core v4 would help.
I have tried to simplify the codesandbox: https://codesandbox.io/s/datagriddemo-material-demo-forked-8myv0?file=/src/demo.js.
- No more emotion cache provider
- Use createGenerateClassName from the v4 package.
|
By the way, do we want to cherry-pick these changelog in the |
I don't think that is needed. At some point, the 2 branches will diverge significantly (when you might need to fix something specifically for v4 for example). I think that changelog should only include v4 related releases (but then again the other way also makes sense). |
|
|
||
| Big thanks to the 3 contributors who made this release possible. Here are some highlights ✨: | ||
|
|
||
| - 👁 Allow to disable virtualization with the `disableVirtualization` prop (#2728) @m4theushw |
There was a problem hiding this comment.
I would personally encourage we make this release the last cherry-pick on the MUI X v4 release line, and document how to use MUI X v5 with MUI Core v4. I think that doing an update on MUI X v4 would only make sense if there is a major issue: Chrome regression, Node.js regression, webpack regression, security hole, etc. Basically, use the policy we had for Core v4 when we were working on Core v5.
There are 1-2 years of inertia with software. MUI Core v4 kept growing during all the time we were working on v5, while we were almost not making any changes.
Of course, if developers complain too much, then we would need to revisit.
There was a problem hiding this comment.
If MUI X v5 + MUI Core v4 is viable (= if users do not find major issues that we would have missed, like weird style collision) I am 100% in favor of this.
There was a problem hiding this comment.
Do we need this feature in v4?
An user asked for it and it was simple to cherry-pick: #1902 (comment)
When we browse the changelog of React do we have to look at different branches to see the whole release history? https://github.com/facebook/react/blob/main/CHANGELOG.md. As far as I know, no, this would be confusing. I do think that having the changelog in HEAD to include the whole history would help developers. So 👍 for a cherry-pick. |
Co-authored-by: Olivier Tassinari <[email protected]>
No description provided.