Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Add Brazilian Portuguese (pt-BR) locale for date pickers #5100

Merged
merged 9 commits into from
Jun 3, 2022

Conversation

jardelnovaes
Copy link
Contributor

More than 210 million people speak Brazilian Portuguese.
More than 70 million people speak European Portuguese.

Supporting pt-BR 'Out of the box' will be nice.

Closes #5099

@mui-bot
Copy link

mui-bot commented Jun 2, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 241.2 505.8 386.4 365.62 104.247
Sort 100k rows ms 468.7 835.5 793.2 733.74 134.148
Select 100k rows ms 115.1 359.2 201.5 219.96 86.218
Deselect 100k rows ms 104.6 251.4 179.7 175.36 51.249

Generated by 🚫 dangerJS against 659d283

@m4theushw m4theushw added the l10n localization label Jun 2, 2022
@m4theushw m4theushw changed the title [DatePicker] Add locale pt-BR [l10n] Add Brazilian Portuguese (pt-BR) locale for date pickers Jun 2, 2022
@jardelnovaes
Copy link
Contributor Author

jardelnovaes commented Jun 2, 2022

@m4theushw I'm "new" here, I accepted one of yours suggestions and the "ci/circleci: test_static" failed, but I think its all right.
Maybe I need to do something, can you help me?

(I accepted right on "commit suggestion button")

@m4theushw
Copy link
Member

You need to run yarn prettier and commit the result. I think it was formatting error caused by my suggestion.

@jardelnovaes
Copy link
Contributor Author

@m4theushw

I was trying to understand, no changes with yarn prettier or yarn prettier check-changed or yarn prettier write-changed.

Finally it worked with yarn prettier write (it processed all files)

Thanks for your help!

@jardelnovaes
Copy link
Contributor Author

jardelnovaes commented Jun 3, 2022

@m4theushw

About the argos step, should I do something? Or just wait?

thanks again for your help!

Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Argos is green now.

@m4theushw m4theushw merged commit 2f53dd7 into mui:master Jun 3, 2022
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DatePicker] Add locale pt-BR
3 participants