[pickers] New unstable field components #5504
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import * as React from 'react'; | ||
| import { LocalizationProvider } from '@mui/x-date-pickers'; | ||
| import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFns'; | ||
| import { Unstable_DateField as DateField } from '@mui/x-date-pickers/DateField'; | ||
|
|
||
| export default function BasicDateField() { | ||
| return ( | ||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||
| <DateField label="Basic date field" /> | ||
| </LocalizationProvider> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import * as React from 'react'; | ||
| import { LocalizationProvider } from '@mui/x-date-pickers'; | ||
| import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFns'; | ||
| import { Unstable_DateField as DateField } from '@mui/x-date-pickers/DateField'; | ||
|
|
||
| export default function BasicDateField() { | ||
| return ( | ||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||
| <DateField label="Basic date field" /> | ||
|
There was a problem hiding this comment. End-users need to click twice to be able to select the year. Compare: Screen.Recording.2022-08-24.at.22.33.21.movhttps://deploy-preview-5504--material-ui-x.netlify.app/x/react-date-pickers/date-field/#basic-usage With (better): Screen.Recording.2022-08-24.at.22.35.41.movhttps://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date There was a problem hiding this comment. This one is a known issue The problem is that I select all sections on focus. And on a fully selected input, I can't find the cursor position of the click, the cursor just moves to the beginning of the input. One solution would be to delay the selection caused by the focus and to skip it if a click selection has been done in the meanwhile. There was a problem hiding this comment.
I would dive into this. I think it's where the problem starts: mui-x/packages/x-date-pickers/src/internals/hooks/useField/useField.ts Lines 319 to 322 in 8db0bfa Maybe instead of a "select all" on focus, the browser does it automatically when focusing an input with a Tab, we could look at There was a problem hiding this comment. I have a PR to improve this behavior #5901 |
||
| </LocalizationProvider> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||
| <DateField label="Basic date field" /> | ||
| </LocalizationProvider> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||
| <DateField | ||
| value={value} | ||
| onChange={(newValue) => { | ||
| setValue(newValue); | ||
| }} | ||
| variant="standard" | ||
| /> | ||
| </LocalizationProvider> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import * as React from 'react'; | ||
| import { LocalizationProvider } from '@mui/x-date-pickers'; | ||
| import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFns'; | ||
| import { Unstable_DateField as DateField } from '@mui/x-date-pickers/DateField'; | ||
| import Stack from '@mui/material/Stack'; | ||
|
|
||
| export default function CustomDateFormat() { | ||
| const [value, setValue] = React.useState(new Date()); | ||
|
|
||
| return ( | ||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||
| <Stack spacing={2} sx={(theme) => ({ width: theme.spacing(48) })}> | ||
| <DateField | ||
| label="Dash separator" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| format="dd-MM-yyyy" | ||
| /> | ||
| <DateField | ||
| label="Dash and white space separator" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| format="dd / MM / yyyy" | ||
| /> | ||
| <DateField | ||
| label="Full letter month" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| format="dd MMMM yyyy" | ||
| /> | ||
| <DateField | ||
| label="Date and time format" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| format="Pp" | ||
| /> | ||
| <DateField | ||
| label="Time format" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| format="p" | ||
| /> | ||
| </Stack> | ||
| </LocalizationProvider> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,46 @@ | ||||||
| import * as React from 'react'; | ||||||
| import { LocalizationProvider } from '@mui/x-date-pickers'; | ||||||
| import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFns'; | ||||||
| import { Unstable_DateField as DateField } from '@mui/x-date-pickers/DateField'; | ||||||
| import Stack from '@mui/material/Stack'; | ||||||
|
|
||||||
| export default function CustomDateFormat() { | ||||||
| const [value, setValue] = React.useState<Date | null>(new Date()); | ||||||
|
|
||||||
| return ( | ||||||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||||||
| <Stack spacing={2} sx={(theme) => ({ width: theme.spacing(48) })}> | ||||||
|
There was a problem hiding this comment. It might make the demo easier to scan:
Suggested change
|
||||||
| <DateField | ||||||
| label="Dash separator" | ||||||
| value={value} | ||||||
| onChange={(newValue) => setValue(newValue)} | ||||||
| format="dd-MM-yyyy" | ||||||
| /> | ||||||
| <DateField | ||||||
| label="Dash and white space separator" | ||||||
| value={value} | ||||||
| onChange={(newValue) => setValue(newValue)} | ||||||
| format="dd / MM / yyyy" | ||||||
| /> | ||||||
| <DateField | ||||||
| label="Full letter month" | ||||||
| value={value} | ||||||
| onChange={(newValue) => setValue(newValue)} | ||||||
| format="dd MMMM yyyy" | ||||||
| /> | ||||||
| <DateField | ||||||
| label="Date and time format" | ||||||
| value={value} | ||||||
| onChange={(newValue) => setValue(newValue)} | ||||||
| format="Pp" | ||||||
| /> | ||||||
| <DateField | ||||||
| label="Time format" | ||||||
| value={value} | ||||||
| onChange={(newValue) => setValue(newValue)} | ||||||
| format="p" | ||||||
| /> | ||||||
| </Stack> | ||||||
| </LocalizationProvider> | ||||||
| ); | ||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import * as React from 'react'; | ||
| import { LocalizationProvider } from '@mui/x-date-pickers'; | ||
| import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFns'; | ||
| import { Unstable_DateField as DateField } from '@mui/x-date-pickers/DateField'; | ||
| import Stack from '@mui/material/Stack'; | ||
| import IconButton from '@mui/material/IconButton'; | ||
| import CancelIcon from '@mui/icons-material/Close'; | ||
|
|
||
| export default function CustomInputProps() { | ||
| const [value, setValue] = React.useState(new Date()); | ||
|
|
||
| return ( | ||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||
| <Stack spacing={2} sx={(theme) => ({ width: theme.spacing(48) })}> | ||
| <DateField | ||
| label="Custom variant" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| variant="filled" | ||
| /> | ||
| <DateField | ||
| label="Disabled" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| disabled | ||
| /> | ||
| <DateField | ||
| label="Read only" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| readOnly | ||
| /> | ||
| <DateField | ||
| label="Clearable" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| InputProps={{ | ||
| endAdornment: ( | ||
| <IconButton size="small" onClick={() => setValue(null)}> | ||
| <CancelIcon /> | ||
| </IconButton> | ||
| ), | ||
| }} | ||
| /> | ||
| </Stack> | ||
| </LocalizationProvider> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import * as React from 'react'; | ||
| import { LocalizationProvider } from '@mui/x-date-pickers'; | ||
| import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFns'; | ||
| import { Unstable_DateField as DateField } from '@mui/x-date-pickers/DateField'; | ||
| import Stack from '@mui/material/Stack'; | ||
| import IconButton from '@mui/material/IconButton'; | ||
| import CancelIcon from '@mui/icons-material/Close'; | ||
|
|
||
| export default function CustomInputProps() { | ||
| const [value, setValue] = React.useState<Date | null>(new Date()); | ||
|
|
||
| return ( | ||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||
| <Stack spacing={2} sx={(theme) => ({ width: theme.spacing(48) })}> | ||
| <DateField | ||
| label="Custom variant" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| variant="filled" | ||
| /> | ||
| <DateField | ||
| label="Disabled" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| disabled | ||
| /> | ||
| <DateField | ||
| label="Read only" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| readOnly | ||
| /> | ||
| <DateField | ||
| label="Clearable" | ||
| value={value} | ||
| onChange={(newValue) => setValue(newValue)} | ||
| InputProps={{ | ||
| endAdornment: ( | ||
| <IconButton size="small" onClick={() => setValue(null)}> | ||
| <CancelIcon /> | ||
| </IconButton> | ||
| ), | ||
| }} | ||
| /> | ||
| </Stack> | ||
| </LocalizationProvider> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import * as React from 'react'; | ||
| import { CssVarsProvider } from '@mui/joy/styles'; | ||
| import Stack from '@mui/material/Stack'; | ||
| import FormControlLabel from '@mui/material/FormControlLabel'; | ||
| import FormLabel from '@mui/joy/FormLabel'; | ||
| import JoyTextField from '@mui/joy/TextField'; | ||
| import InputUnstyled from '@mui/base/InputUnstyled'; | ||
| import { LocalizationProvider } from '@mui/x-date-pickers'; | ||
| import { AdapterDateFns } from '@mui/x-date-pickers/AdapterDateFns'; | ||
| import { unstable_useDateField as useDateField } from '@mui/x-date-pickers/DateField'; | ||
|
|
||
| const JoyDateField = (props) => { | ||
| const { inputRef, inputProps } = useDateField(props); | ||
|
|
||
| return ( | ||
| <JoyTextField | ||
| {...inputProps} | ||
| componentsProps={{ input: { componentsProps: { input: { ref: inputRef } } } }} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| const UnstyledDateField = (props) => { | ||
| const { inputRef, inputProps } = useDateField(props); | ||
|
|
||
| return ( | ||
| <InputUnstyled | ||
| {...inputProps} | ||
| componentsProps={{ input: { ref: inputRef, style: { width: '100%' } } }} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| const BrowserInputDateField = (props) => { | ||
| const { inputRef, inputProps } = useDateField(props); | ||
|
|
||
| return <input {...inputProps} ref={inputRef} />; | ||
| }; | ||
|
|
||
| export default function CustomUIDateField() { | ||
| const [value, setValue] = React.useState(new Date()); | ||
|
|
||
| const handleChange = (newValue) => setValue(newValue); | ||
|
|
||
| return ( | ||
| <CssVarsProvider> | ||
| <LocalizationProvider dateAdapter={AdapterDateFns}> | ||
| <Stack spacing={2}> | ||
| <JoyDateField | ||
| label="Using @mui/joy TextField" | ||
| value={value} | ||
| onChange={handleChange} | ||
| /> | ||
| <FormControlLabel | ||
| label={<FormLabel>Using unstyled input</FormLabel>} | ||
| control={<UnstyledDateField value={value} onChange={handleChange} />} | ||
| labelPlacement="top" | ||
| sx={{ alignItems: 'stretch' }} | ||
| /> | ||
| <FormControlLabel | ||
| label={<FormLabel>Using browser input</FormLabel>} | ||
| control={<BrowserInputDateField value={value} onChange={handleChange} />} | ||
| labelPlacement="top" | ||
| sx={{ alignItems: 'stretch' }} | ||
| /> | ||
| </Stack> | ||
| </LocalizationProvider> | ||
| </CssVarsProvider> | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we allow 00?
Maybe we should reset the field when this happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know for this one
In Spectrum, if I press
0it does not write anything, even if the end format will be01Press
0=> still render the placeholder (totally ignores the event I think)Press
1=> renders01There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more precise, I was thinking of what would happen when leaving the selection. A native browser seems to turn 00 to 01 when unselecting.