-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Fix grid size calculation when .MuiDataGrid-main
has border
#8882
[DataGrid] Fix grid size calculation when .MuiDataGrid-main
has border
#8882
Conversation
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8882--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The applied changes seem to fix the regression, thank you! 🎉
// It should not have a horizontal scrollbar | ||
expect(virtualScroller.scrollWidth - virtualScroller.clientWidth).to.equal(0); | ||
|
||
await sleep(200); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious if clock.tick
could be used here alternatively too 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's an option too, but we'll need to use a fake clock for this.
If this test turns out to be flaky, I'll give it a try! 👍
Fixes #8737
Scenario 1:
Before: https://codesandbox.io/s/data-grid-community-forked-3ctumy
After: https://codesandbox.io/s/data-grid-community-forked-4glro7
Scenario 2:
Before: https://codesandbox.io/s/sparkling-waterfall-3sdhkk?file=/demo.tsx
After: https://codesandbox.io/s/vigilant-curran-xgf9pt