Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Add Chinese (Hong Kong) (zh-HK) locale #9468

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Conversation

samchiu90
Copy link
Contributor

@samchiu90 samchiu90 commented Jun 26, 2023

Add Traditional Chinese text in Hong Kong (zhHK) locale for date-pickers

@mui-bot
Copy link

mui-bot commented Jun 26, 2023

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Verify that you have added an export line in src/locales/index.ts for the new locale.
  • Run yarn docs:api which should add your new translation to the list of exported interfaces.
  • Clean files with yarn prettier.

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9468--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 502.3 999.7 771.5 732.14 168.48
Sort 100k rows ms 657 999.7 947.8 897.74 127.07
Select 100k rows ms 195.1 466.9 258.4 305.24 97.062
Deselect 100k rows ms 146.6 365.8 215.8 228.2 74.325

Generated by 🚫 dangerJS against dc6e639

@LukasTy LukasTy added l10n localization component: pickers This is the name of the generic UI component, not the React module! labels Jun 26, 2023
@LukasTy LukasTy changed the title [l10n] Add Traditional Chinese text in Hong Kong (zhHK) locale for date-pickers [l10n] Add Chinese (Hong Kong) (zh-HK) locale Jun 26, 2023
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏
Have you ran the yarn l10n script on Windows and it generated links with double backslahes (\\) instead of a froward slash (/)? 🤔

@LukasTy LukasTy merged commit 75d015b into mui:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants