[docs] Remove "product" markdown header #9517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9517--material-ui-x.netlify.app/ Updated pages
These are the results for the performance tests:
|
| @@ -1,6 +1,7 @@ | |||
| --- | |||
| product: charts | |||
| title: Charts - Overview | |||
| title: React Chart components | |||
There was a problem hiding this comment.
We will see how high we can rank, I have added us in https://app.ahrefs.com/rank-tracker/overview/2944028.
LukasTy
reviewed
Jun 29, 2023
LukasTy
approved these changes
Jun 30, 2023
m4theushw
added a commit
to m4theushw/mui-x
that referenced
this pull request
Jun 30, 2023
oliviertassinari
added a commit
that referenced
this pull request
Jul 3, 2023
Rebase conflict with #9517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix related to mui/material-ui#37729, AFAIK, these header
productproperties have no logic associated with them, it's noise, we rely on the URL. I have only added them on the migration pages where we can't be URL based, and where a change in the docs-infra could make these headers valuable to improve the Algolia search UX