[core] Temporarily fallback to v5 of Material UI #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brijeshb42
commented
Aug 7, 2024
brijeshb42
commented
- Fixes the issues with the current build failing for the latest beta of @mui/material package. To be investigated separately (to unblock release) since it does not directly concern Pigment CSS.
- Fixed some TS errors coming from emotion.
- Updated WyW to latest version.
- I have followed (at least) the PR section of the contributing guide.
This fixes the issues with the current build failing for the latest beta of @mui/material package. To be investigated separately since it does not directly concern Pigment. Also fixed some TS errors coming from emotion and updated WyW packages.
siriwatknp
reviewed
Aug 7, 2024
| @@ -1,7 +1,7 @@ | |||
| /* eslint-env node */ | |||
| // eslint-ignore-next-line import/no-unresolved | |||
| const { withPigment } = require('@pigment-css/nextjs-plugin'); | |||
| const { extendTheme } = require('@mui/material/styles'); | |||
| const { experimental_extendTheme: extendTheme } = require('@mui/material/styles'); | |||
There was a problem hiding this comment.
Is this part of the root cause that the CI fails?
siriwatknp
approved these changes
Aug 7, 2024
siriwatknp
requested changes
Aug 7, 2024
That does not concern the app in this repo. Pigment has a fallback for this method. I have to investigate more to pinpoint the exact version of Material UI that is causing the issue. But I don't want to block release for that. |
siriwatknp
reviewed
Aug 7, 2024
Comment on lines
+13
to
+14
| "@mui/material": "^5.16.6", | ||
| "@mui/material-nextjs": "^5.16.6", |
There was a problem hiding this comment.
Can you change to 6.0.0-beta.2 if the latest beta fails.
There was a problem hiding this comment.
It does not make sense to use v5.
There was a problem hiding this comment.
beta.2 also has the same issue.
siriwatknp
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.