core: Bump package versions and fix related TS errors #294
Conversation
There is also a small change in how we do conversion for !important. Currently, we do it by replacing ! with __IMP__ and then reconverting back. In this PR, I have changed that to just encode and decode to and from base64. So we don't need special handling for ! character
brijeshb42
force-pushed
the
bump-versions
branch
from
b454dca to
3cbf2bd
Compare
brijeshb42
force-pushed
the
bump-versions
branch
from
de50315 to
5e63464
Compare
| "@types/node": "^20.5.7", | ||
| "@types/react": "^18.3.3", | ||
| "@types/react-dom": "^18.2.19", | ||
| "@types/node": "^18.19.63", |
There was a problem hiding this comment.
This's a downgrade. Is this correct?
There was a problem hiding this comment.
It is. v20 never actually was used since at the root, in resolutions, it was still v18. I have kept it at 18 since we are currently using node v18 to build in CI.
| @@ -1,7 +1,7 @@ | |||
| /* eslint-env node */ | |||
| // eslint-ignore-next-line import/no-unresolved | |||
| const { withPigment } = require('@pigment-css/nextjs-plugin'); | |||
| const { experimental_extendTheme: extendTheme } = require('@mui/material/styles'); | |||
| const { extendTheme } = require('@mui/material/styles'); | |||
There was a problem hiding this comment.
For a next PR, we could just use createTheme with the css vars option.
There was a problem hiding this comment.
Sure. I'll update it in the actual docs PR.
| "@mui/system": "next", | ||
| "@mui/icons-material": "next", | ||
| "clsx": "^2.1.0", | ||
| "@mui/utils": "6.1.6", |
There was a problem hiding this comment.
We should replace these to latest, no?
There was a problem hiding this comment.
IMO, it makes sense for examples. But for local apps, I'd prefer to manually update the versions since some of the things started breaking especially since currently v5 was being used (in the lockfile).
| @@ -1,6 +1,6 @@ | |||
| export const loader = function virtualFileLoader() { | |||
| const callback = this.async(); | |||
| const resourceQuery = this.resourceQuery.slice(1); | |||
| const { source } = JSON.parse(decodeURIComponent(resourceQuery)); | |||
| return callback(null, source.replaceAll('__IMP__', '!important')); | |||
| const { source } = JSON.parse(decodeURIComponent(decodeURI(atob(resourceQuery)))); | |||
| @@ -9,7 +9,7 @@ import type { | |||
| } from '@wyw-in-js/processor-utils'; | |||
| import type { Replacements, Rules } from '@wyw-in-js/shared'; | |||
| import { ValueType } from '@wyw-in-js/shared'; | |||
| import type { CSSInterpolation } from '@emotion/css'; | |||
| import type { CSSInterpolation } from '@emotion/serialize'; | |||
There was a problem hiding this comment.
How did this breaking change land in an minor 😕
There was a problem hiding this comment.
Yeah. I was surprised as well.
There was one breaking change in Emotion. Some common types had been moved to
@emotion/serialize.There is also a small change in how we do conversion for !important. Currently, we do it by replacing ! with IMP and then reconverting back.
In this PR, I have changed that to just encode and decode to and from base64. So we don't need special handling for
!character.I encountered these errors while setting up the Pigment CSS docs workspace.