[enhancement] Reorder the css generation order for styled calls #56
Conversation
brijeshb42
added
enhancement
brijeshb42
force-pushed
the
override-precedence
branch
from
a5dc82c to
5d3f230
Compare
|
Tested, it works like a charm! |
to match with @mui/system Fixes mui#55
brijeshb42
force-pushed
the
override-precedence
branch
from
5d3f230 to
983a6a8
Compare
There was a problem hiding this comment.
Nice catch. I can understand how both of these orders would make sense. Personally, I would go with the previous implementation, where basic styles override basic styles, and variants override variants - we weren't able to do this previously with emotion, as the styles were defined via callback and people could have used props there. I remember for example this issue: mui/material-ui#29529 where the order was not really intuitive.
I will try to get more insights into what would be more intuitive solution.
| * 3. Variants declared in styled call | ||
| * 2. CSS declared in theme object's styledOverrides |
There was a problem hiding this comment.
The number of the list are wrong.
|
Yeah. The only reason to change this is to maintain compatibility with system. I had also discussed this order way back during the early implementations and why that made sense. |
to match with @mui/system
Fixes #55